From 2548d4f32b2d9fed56e62ef460b4bdcedbba4afa Mon Sep 17 00:00:00 2001 From: brunobenchimol Date: Mon, 15 Nov 2021 20:36:54 -0300 Subject: [PATCH] ansible lint fixes -- hopefully all are fixed now --- defaults/main.yml | 6 +++--- tasks/create-cert-dns-plugin.yml | 4 ++-- tasks/delete-cert.yml | 4 ++-- tasks/install-with-snap.yml | 4 ++-- tasks/main.yml | 2 +- vars/main.yml | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/defaults/main.yml b/defaults/main.yml index c9c5a3b..1757c08 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -59,8 +59,8 @@ certbot_dns_create_command: >- certbot_create_dns_deploy_hook_services: - haproxy - #- nginx - #- apache + # - nginx + # - apache certbot_create_standalone_stop_services: - nginx @@ -69,7 +69,7 @@ certbot_create_standalone_stop_services: certbot_delete_command: >- {{ certbot_script }} delete --noninteractive - --cert-name {{ cert_item.domains | first | replace('*.', '') }} + --cert-name {{ cert_item.domains | first | replace('*.', '') }} # Available options: 'package', 'snap', 'source'. certbot_install_method: 'package' diff --git a/tasks/create-cert-dns-plugin.yml b/tasks/create-cert-dns-plugin.yml index ddbf6ce..75396c7 100644 --- a/tasks/create-cert-dns-plugin.yml +++ b/tasks/create-cert-dns-plugin.yml @@ -27,7 +27,7 @@ - name: "Create DNS RFC {{ certbot_dns_plugin }} Credentials File." template: src: dns_plugin_credentials.j2 - dest: "{{certbot_dns_credentials_file}}" + dest: "{{ certbot_dns_credentials_file }}" owner: root group: root mode: 0600 @@ -45,7 +45,7 @@ when: - certbot_dns_plugin != 'rfc2136' - certbot_dns_credentials_custom_file is defined - + - name: Generate new certificate if one doesn't exist. command: "{{ certbot_dns_create_command }}" when: not letsencrypt_cert.stat.exists diff --git a/tasks/delete-cert.yml b/tasks/delete-cert.yml index ec34f9e..458922c 100644 --- a/tasks/delete-cert.yml +++ b/tasks/delete-cert.yml @@ -6,7 +6,7 @@ - name: Delete Certificate command: "{{ certbot_delete_command }}" - when: + when: - letsencrypt_cert.stat.exists - certbot_delete_certificate|bool @@ -14,7 +14,7 @@ file: path: /etc/letsencrypt/live/{{ cert_item.domains | first | replace('*.', '') }} state: absent - when: + when: - letsencrypt_cert.stat.exists - certbot_delete_certificate|bool diff --git a/tasks/install-with-snap.yml b/tasks/install-with-snap.yml index d5aedab..2c7123b 100644 --- a/tasks/install-with-snap.yml +++ b/tasks/install-with-snap.yml @@ -37,12 +37,12 @@ - name: Make sure certbot Trust Plugins With Root is set. command: snap set certbot trust-plugin-with-root=ok - when: + when: - certbot_dns_plugin is defined - name: Install DNS Plugin - {{ certbot_dns_plugin }}. snap: - name: "certbot-dns-{{certbot_dns_plugin}}" + name: "certbot-dns-{{ certbot_dns_plugin }}" classic: true when: certbot_dns_plugin is defined diff --git a/tasks/main.yml b/tasks/main.yml index ba624fe..46ab38c 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -39,5 +39,5 @@ loop_var: cert_item - import_tasks: renew-cron.yml - when: + when: - certbot_auto_renew diff --git a/vars/main.yml b/vars/main.yml index 4707792..5aa9706 100644 --- a/vars/main.yml +++ b/vars/main.yml @@ -1,5 +1,5 @@ --- -certbot_dns_credentials_file: "/etc/letsencrypt/dns-{{certbot_dns_plugin}}-credentials" +certbot_dns_credentials_file: "/etc/letsencrypt/dns-{{ certbot_dns_plugin }}-credentials" certbot_supported_dns_plugins: - rfc2136 - cloudflare