From 7efc6a50f57ab08dc41fb594a0f5dbec3810947c Mon Sep 17 00:00:00 2001 From: Jeff Geerling Date: Thu, 16 May 2019 22:07:42 -0500 Subject: [PATCH 1/2] Remove unused tests. --- molecule/default/tests/test_default.py | 14 -------------- 1 file changed, 14 deletions(-) delete mode 100644 molecule/default/tests/test_default.py diff --git a/molecule/default/tests/test_default.py b/molecule/default/tests/test_default.py deleted file mode 100644 index eedd64a..0000000 --- a/molecule/default/tests/test_default.py +++ /dev/null @@ -1,14 +0,0 @@ -import os - -import testinfra.utils.ansible_runner - -testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner( - os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all') - - -def test_hosts_file(host): - f = host.file('/etc/hosts') - - assert f.exists - assert f.user == 'root' - assert f.group == 'root' From a49d4e63a1b97968327195450bd9fe0058c8d920 Mon Sep 17 00:00:00 2001 From: Jeff Geerling Date: Mon, 26 Aug 2019 11:56:43 -0500 Subject: [PATCH 2/2] Fixes #91: Warnings for ints in string fields in Ansible 2.8.x. --- README.md | 8 ++++---- defaults/main.yml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 599ebb0..a720e0d 100644 --- a/README.md +++ b/README.md @@ -16,8 +16,8 @@ The variable `certbot_install_from_source` controls whether to install Certbot f certbot_auto_renew: true certbot_auto_renew_user: "{{ ansible_user | default(lookup('env', 'USER')) }}" - certbot_auto_renew_hour: 3 - certbot_auto_renew_minute: 30 + certbot_auto_renew_hour: "3" + certbot_auto_renew_minute: "30" certbot_auto_renew_options: "--quiet --no-self-upgrade" By default, this role configures a cron job to run under the provided user account at the given hour and minute, every day. The defaults run `certbot renew` (or `certbot-auto renew`) via cron every day at 03:30:00 by the user you use in your Ansible playbook. It's preferred that you set a custom user/hour/minute so the renewal is during a low-traffic period and done by a non-root user account. @@ -91,8 +91,8 @@ None. vars: certbot_auto_renew_user: your_username_here - certbot_auto_renew_minute: 20 - certbot_auto_renew_hour: 5 + certbot_auto_renew_minute: "20" + certbot_auto_renew_hour: "5" roles: - geerlingguy.certbot diff --git a/defaults/main.yml b/defaults/main.yml index 3186d8e..7002b26 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -2,8 +2,8 @@ # Certbot auto-renew cron job configuration (for certificate renewals). certbot_auto_renew: true certbot_auto_renew_user: "{{ ansible_user | default(lookup('env', 'USER')) }}" -certbot_auto_renew_hour: 3 -certbot_auto_renew_minute: 30 +certbot_auto_renew_hour: "3" +certbot_auto_renew_minute: "30" certbot_auto_renew_options: "--quiet --no-self-upgrade" # Parameters used when creating new Certbot certs.