mirror of
https://github.com/geerlingguy/ansible-role-certbot.git
synced 2026-05-28 13:31:15 +02:00
88632e986e
certbot 5.x renamed the field in `certbot certificates` output from "Domains:" to "Identifiers:". The "Check if domains have changed" task greps that output for "Domains" to read a certificate's current domains. On certbot 5.x the grep matches nothing, so letsencrypt_cert_domains becomes empty, letsencrypt_cert_domains_changed is always true, and every certificate is reissued on every run. Match both the old "Domains" and new "Identifiers" labels in create-cert-standalone.yml and create-cert-webroot.yml so the check works on certbot 4.x and 5.x alike.
36 lines
1.3 KiB
YAML
36 lines
1.3 KiB
YAML
---
|
|
- name: Determine certificate name
|
|
set_fact:
|
|
cert_item_name: "{{ cert_item.name | default(cert_item.domains | first | replace('*.', '')) }}"
|
|
|
|
- name: Check if certificate already exists.
|
|
stat:
|
|
path: /etc/letsencrypt/live/{{ cert_item_name }}/cert.pem
|
|
register: letsencrypt_cert
|
|
|
|
- name: Create webroot directory if it doesn't exist yet
|
|
file:
|
|
path: "{{ cert_item.webroot | default(certbot_webroot) }}"
|
|
state: directory
|
|
|
|
- name: Check if domains have changed
|
|
block:
|
|
- name: Register certificate domains
|
|
shell: "{{ certbot_script }} certificates --cert-name {{ cert_item_name }} | grep -E 'Domains|Identifiers' | cut -d':' -f2"
|
|
changed_when: false
|
|
register: letsencrypt_cert_domains_dirty
|
|
|
|
- name: Cleanup domain list
|
|
set_fact:
|
|
letsencrypt_cert_domains: "{{ letsencrypt_cert_domains_dirty.stdout | trim | split(' ') | map('trim') | select('!=', '') | list | sort }}"
|
|
|
|
- name: Determine if domains have changed
|
|
set_fact:
|
|
letsencrypt_cert_domains_changed: "{{ letsencrypt_cert_domains != (cert_item.domains | map('trim') | select('!=', '') | list | sort) }}"
|
|
|
|
when: letsencrypt_cert.stat.exists
|
|
|
|
- name: Generate new certificate if one doesn't exist.
|
|
command: "{{ certbot_create_command }}"
|
|
when: not letsencrypt_cert.stat.exists or letsencrypt_cert_domains_changed | default(false)
|
