From b849828c9b343958a043b2cb0f363e92cc3ab0c9 Mon Sep 17 00:00:00 2001 From: Pierre Roudier Date: Tue, 25 Jun 2024 00:40:04 -0400 Subject: [PATCH] fix: respect ~/.kube/config as a symlink (#1455) --- pkg/client/kubeconfig.go | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/pkg/client/kubeconfig.go b/pkg/client/kubeconfig.go index 31ea94bf..3eb503f4 100644 --- a/pkg/client/kubeconfig.go +++ b/pkg/client/kubeconfig.go @@ -283,12 +283,22 @@ func KubeconfigWrite(ctx context.Context, kubeconfig *clientcmdapi.Config, path return fmt.Errorf("failed to write merged kubeconfig to temporary file '%s': %w", tempPath, err) } + // In case path is a symlink, retrives the name of the target + realPath, err := filepath.EvalSymlinks(path) + if err != nil { + return fmt.Errorf("failed to follow symlink '%s': %w", path, err) + } + // Move temporary file over existing KubeConfig - if err := os.Rename(tempPath, path); err != nil { + if err := os.Rename(tempPath, realPath); err != nil { return fmt.Errorf("failed to overwrite existing KubeConfig '%s' with new kubeconfig '%s': %w", path, tempPath, err) } - l.Log().Debugf("Wrote kubeconfig to '%s'", path) + extraLog := "" + if filepath.Clean(path) != realPath { + extraLog = fmt.Sprintf("(via symlink '%s')", path) + } + l.Log().Debugf("Wrote kubeconfig to '%s' %s", realPath, extraLog) return nil }