Deprecate --timeout, shift shot hand options around

We have been giving user warnings about --timeout going away for a
while. Now fully deprecate it.

Use -t for --wait option

Move -w from --wait to --workers. Many users of K3d generate multi-node
clusters, -w will make their life easier.
pull/76/head
Andy Zhou 5 years ago
parent 8a59078c87
commit f037e1b225
  1. 4
      cli/commands.go
  2. 9
      main.go

@ -161,10 +161,6 @@ func CreateCluster(c *cli.Context) error {
return err
}
if c.IsSet("timeout") {
log.Println("[Warning] The --timeout flag is deprecated. use '--wait <timeout>' instead")
}
// Wait for k3s to be up and running if wanted.
// We're simply scanning the container logs for a line that tells us that everything's up and running
// TODO: also wait for worker nodes

@ -103,12 +103,7 @@ func main() {
Usage: "Specify the Kubernetes cluster API server port (Format: `[host:]port` (Note: --port/-p will be used for arbitrary port mapping as of v2.0.0, use --api-port/-a instead for setting the api port)",
},
cli.IntFlag{
Name: "timeout, t",
Value: 0,
Usage: "Set the timeout value when --wait flag is set (deprecated, use --wait <timeout> instead)",
},
cli.IntFlag{
Name: "wait, w",
Name: "wait, t",
Value: 0, // timeout
Usage: "Wait for the cluster to come up before returning until timoout (in seconds). Use --wait 0 to wait forever",
},
@ -126,7 +121,7 @@ func main() {
Usage: "Pass an additional environment variable (new flag per variable)",
},
cli.IntFlag{
Name: "workers",
Name: "workers, w",
Value: 0,
Usage: "Specify how many worker nodes you want to spawn",
},

Loading…
Cancel
Save