From aa37fc19c067a0380902f0b3265e4d15f33557c3 Mon Sep 17 00:00:00 2001 From: "Alex Ellis (OpenFaaS Ltd)" Date: Mon, 3 Aug 2020 18:24:04 +0100 Subject: [PATCH] Update PR template and Derek file Signed-off-by: Alex Ellis (OpenFaaS Ltd) --- .DEREK.yml | 3 ++- .github/ISSUE_TEMPLATE.md | 36 -------------------------------- .github/PULL_REQUEST_TEMPLATE.md | 5 ++++- 3 files changed, 6 insertions(+), 38 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE.md diff --git a/.DEREK.yml b/.DEREK.yml index 5a962d6..896e6ee 100644 --- a/.DEREK.yml +++ b/.DEREK.yml @@ -1,6 +1,7 @@ maintainers: - alexellis - - rgee0 + - Waterdrips + - utsavanand2 features: - dco_check diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md deleted file mode 100644 index 5a4312b..0000000 --- a/.github/ISSUE_TEMPLATE.md +++ /dev/null @@ -1,36 +0,0 @@ - - -## Expected Behaviour - - - -## Current Behaviour - - - -## Possible Solution - - - -## Steps to Reproduce (for bugs) - - -1. -2. -3. -4. - -## Context - - - -## Your Environment - - -* Docker version `docker version` (e.g. Docker 17.0.05 ): - -* What version of Kubernetes are you using? `kubectl version`: - -* Operating System and version (e.g. Linux, Windows, MacOS): - -* What ARM or Raspberry Pi board are you using? diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index de9ee06..9cc0b49 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -26,5 +26,8 @@ - [ ] My code follows the code style of this project. - [ ] I have tested this change and prove it works - [ ] I've read the [CONTRIBUTION](https://github.com/alexellis/k8s-on-raspbian#contributions) guide -- [ ] I have signed-off my commits with `git commit -s` +## Required for merge: + +- [ ] I have signed-off my commits, fix with: `git commit --amend --signoff` +- [ ] My PR only contains one commit, fix with: `git rebase -i HEAD~N`, where `N` = number of commits.