Enhanced Dockerfile snippet in README.md The Dockerfile snippet in the README.md file required adjustments to align it more closely with the actual Dockerfiles in both the Backend and Frontend directories. I've made a few improvements to ensure clarity and accuracy. Original Snippet in Repository: FROM node:13.13.0-stretch-slim # Argument passed from docker-compose.yaml file ARG NODE_PORT # Echo the argument to check if it's loaded correctly RUN echo "Argument port is: $NODE_PORT" # Create app directory WORKDIR /usr/src/app # Copy entire content COPY . . # Install app dependencies RUN npm install # My app binds to port NODE_PORT; use the EXPOSE instruction for Docker daemon mapping: EXPOSE ${NODE_PORT} CMD npm run dev Modified Snippet: FROM node:13.13.0-stretch-slim # Argument passed from docker-compose.yaml file ARG NODE_PORT # Echo the argument to check if it's loaded correctly RUN echo "Argument port is: $NODE_PORT" # Create app directory WORKDIR /usr/src/app # Copy dependency definitions first for better Docker caching COPY package.json /usr/src/app # Install app dependencies RUN npm install # Copy the entire application code COPY . /usr/src/app # My app binds to port NODE_PORT; use the EXPOSE instruction for Docker daemon mapping: EXPOSE ${NODE_PORT} CMD npm run dev These changes ensure consistency and readability. Signed-off-by: Thoshinny B <69354714+Thoshinny-cyber@users.noreply.github.com>pull/405/head
parent
e6b1d2755f
commit
c2071c0e14
Loading…
Reference in new issue